Repository navigation
[py] cleanup for ruff rule sim102 . part of the tranche 3 stage - #18034
Conversation
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved issues were identified.
Pull request overview
This PR enables Ruff SIM102 and simplifies equivalent nested conditionals across five Python files without intended behavior changes.
Changes:
- Adds
SIM102to Ruff enforcement. - Flattens nested conditional logic.
File summaries
| File | Summary |
|---|---|
py/selenium/webdriver/remote/server.py |
Simplifies version validation. |
py/selenium/webdriver/firefox/firefox_profile.py |
Simplifies namespace detection. |
py/pyproject.toml |
Enables SIM102. |
py/generate_api_module_listing.py |
Simplifies module filtering. |
py/conftest.py |
Simplifies traceback, BiDi, and teardown conditions. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
@cgoldberg please review. I'm going to continue working on the root issue with the remaining Ruff warnings. |
cgoldberg
left a comment
There was a problem hiding this comment.
@iampopovich I think this is good to merge
|
@cgoldberg thanks, in the end of this week I'll take the next batch of warnings to fix |
🔗 Related Issues
partially resolves #17989
💥 What does this PR do?
fixes warnings for ruff rule sim102. it was choosen by me as mostly easy to implement with non-breaking changes
🔧 Implementation Notes
🤖 AI assistance
💡 Additional Considerations
🔄 Types of changes