Skip to content

[dotnet] [bidi] Align CapabilityResponse type name with spec - #18099

Merged
nvborisenko merged 1 commit into
SeleniumHQ:trunkfrom
nvborisenko:bidi-capability-response
Sep 30, 2026
Merged

nvborisenko merged 1 commit into
SeleniumHQ:trunkfrom
nvborisenko:bidi-capability-response

Conversation

@nvborisenko

Copy link
Copy Markdown
Member

https://w3c.github.io/webdriver-bidi/#cddl-type-sessionnew

Spec defined anonymous type to be CapabilityResponse.

💥 What does this PR do?

This pull request updates type definitions related to session capabilities in the BiDi WebDriver implementation. The main change is the renaming of the Capabilities record to CapabilityResponse, which also affects its usage in related types.

Type definition updates:

  • Renamed the Capabilities record to CapabilityResponse in dotnet/src/webdriver/BiDi/Session/New.cs to clarify its purpose and usage.
  • Updated the NewResult record to use CapabilityResponse instead of the old Capabilities type for its Capabilities property.

🤖 AI assistance

  • No substantial AI assistance used
  • AI assisted (complete below)
    • Tool(s):
    • What was generated:
    • I reviewed all AI output and can explain the change

🔄 Types of changes

  • Cleanup (formatting, renaming)

@qodo-code-review

Copy link
Copy Markdown
Contributor

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@selenium-ci selenium-ci added the C-dotnet .NET Bindings label Sep 30, 2026
@nvborisenko
nvborisenko merged commit 89f967d into SeleniumHQ:trunk Sep 30, 2026
27 checks passed
@nvborisenko
nvborisenko deleted the bidi-capability-response branch September 30, 2026 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-dotnet .NET Bindings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Sponsor
SponsoredKunjungi sekarang
Promo