Skip to content

[py] Adopt all Ruff FURB rules - #18168

Merged
cgoldberg merged 4 commits into
SeleniumHQ:trunkfrom
goldpanth3r:py-ruff-tranche-1
Oct 14, 2026
Merged

cgoldberg merged 4 commits into
SeleniumHQ:trunkfrom
goldpanth3r:py-ruff-tranche-1

Conversation

@goldpanth3r

@goldpanth3r goldpanth3r commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

🔗 Related Issues

Related to #17989

💥 What does this PR do?

  • Enable the complete Ruff FURB rule family in the Python lint configuration.

  • Replace ternary expressions with or where appropriate (FURB110).

  • Replace single-item membership checks with direct inequality comparisons (FURB171).

🤖 AI assistance

  • No substantial AI assistance used
  • AI assisted (complete below)
    • Tool(s):
    • What was generated:
    • I reviewed all AI output and can explain the change

🔄 Types of changes

  • New feature (non-breaking change which adds functionality and tests!)

@qodo-code-review

Copy link
Copy Markdown
Contributor

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@selenium-ci selenium-ci added the C-py Python Bindings label Oct 13, 2026
@CLAassistant

CLAassistant commented Oct 13, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@cgoldberg cgoldberg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 I like refurb.

@goldpanth3r please sign the CLA to get this merged: #18168 (comment)

@cgoldberg cgoldberg changed the title Adopt all Ruff FURB rules by adding FURB110 and FURB171 [py] Adopt all Ruff FURB rules Oct 13, 2026
@goldpanth3r

goldpanth3r commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor Author

Thanks for the review @cgoldberg ! I've signed the CLA.

@cgoldberg

Copy link
Copy Markdown
Member

merging.. thanks for your first contribution!

@cgoldberg
cgoldberg merged commit b47faab into SeleniumHQ:trunk Oct 14, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-py Python Bindings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Sponsor
SponsoredKunjungi sekarang
Promo