Skip to content
This repository was archived by the owner on Sep 24, 2018. It is now read-only.
This repository was archived by the owner on Sep 24, 2018. It is now read-only.

Disambiguate between trashed and permanently deleted Posts and Comments #1260

Description

@danielbachhuber

In develop, a client making a DELETE request to Posts or Comments has no way of distinguishing between whether the request trashed the resource or permanently deleted it. We should provide this detail.

From #1224

Also, 2x DELETE wp/v2/comments/<id> will permanently delete a comment, but 2x DELETE wp/v2/posts/<id> will return some rest_already_deleted error (2d5cf2c, #959). We should make sure these are consistent.

Activity

  1. added this to the 2.0 Beta 2 milestone on May 19, 2015
  2. rmccue commented on May 28, 2015

    @rmccue
    Member

    #1271 should help out with this for now, but we want to also wrap the data in an object with a trashed/deleted key. This intentionally won't match the data itself, since we're not returning the resource as-it-currently-is, but rather as-it-was-before-the-call-executed.

    Let's bump to b3 though, as we might want to be semi-consistent with #1196 (e.g. use data in both)?

  3. modified the milestones: 2.0 Beta 3, 2.0 Beta 2 on May 28, 2015
  4. rachelbaker commented on Jun 15, 2015

    @rachelbaker
    Member

    Punted to Beta 4

  5. modified the milestones: 2.0, 2.0 Beta 4 on Aug 7, 2015
  6. danielbachhuber commented on Jan 30, 2016

    @danielbachhuber
    MemberAuthor

    After a little bit of discussion, we're going to return the original resource instead of wrapping it in a data object.

  7. danielbachhuber commented on Jan 30, 2016

    @danielbachhuber
    MemberAuthor

    🚢 🚢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

    Sponsor
    SponsoredKunjungi sekarang
    Promo