This repository was archived by the owner on Sep 24, 2018. It is now read-only.
Repository navigation
This repository was archived by the owner on Sep 24, 2018. It is now read-only.
Audit and improve hook docs #1549
Description
Looking forward to the core merge, we should make sure our hook docs follow core standards and will be easily parseable. Scanning thru the existing code, some hooks are documented while others are not.
Here is an inventory of project files where I found hooks and will be going thru to update/add docs:
- plugin.php
- extras.php
- lib/endpoints/class-wp-rest-attachments-controller.php
- lib/endpoints/class-wp-rest-comments-controller.php
- lib/endpoints/class-wp-rest-meta-controller.php
- lib/endpoints/class-wp-rest-posts-controller.php
- lib/endpoints/class-wp-rest-taxonomies-controller.php
- lib/endpoints/class-wp-rest-terms-controller.php
- lib/endpoints/class-wp-rest-users-controller.php
- lib/infrastructure/class-wp-rest-request.php
- lib/infrastructure/class-wp-rest-server.php
Activity
adamsilverstein commentedon Sep 18, 2015
Making good progress on the hook docs. During the hook audit, I noticed the absence of several hooks in some places. For example, actions are not fired when terms or taxonomies are added or updated (posts have such actions). This appears to be an oversight, so I will go back and add the missing hooks to try to make pattern as consistent as possible and have hooks everywhere you would expect them as a developer.
I also noticed that no actions are fired on delete anywhere, which I think would be worth remedying. Feedback?
adamsilverstein commentedon Sep 18, 2015
Another note from the audit: We should add unit tests to verify the hooks are fired correctly.
rachelbaker commentedon Sep 20, 2015
@adamsilverstein looks like all 11 items have been checked-off, and other issues have been filed for the additional issues you discovered. Can this issue be closed?
adamsilverstein commentedon Sep 21, 2015
yep, closing.