Use cURL over file_get_content when available - #3500

follow_location does not work under certain circumstances

Under what circumstances? Follow location is disabled by default. When enabled, under what circumstances does it not work with file_get_contents?

Helpers::encodeURI still corrupts some characters (@ symbol)

Do you have a sample URL?

In my use case images point to some API that redirects to the actual image in Google Cloud Storage.

ie. https://storage.googleapis.com/foc-files/dev/private/5e2b15573533314e494a74f2/8b/dd/a3/66a0d03033cbadbc6c003b82_rendez_vos_pdf_interactifs_directement_sur_franchise_on_cloud_v2.png?fileRevision=1721815088&GoogleAccessId=extranet%40franchise-on-cloud.iam.gserviceaccount.com&Expires=1721944800&Signature=DMH5GiL07NmB9IjawapE5%2B%2FmKg29aIyqukjXXkD6aeqUiResrBiNV%2Bk%2B%2FfsWYw3y0AvdDIWy%2BBlCauH85g%2Fs0TNZiU88%2BIitXswaGS%2BraoZB7pvi96pbIRY5M4%2FhLn9nNF5IwkUfGctxeA1K%2FFm5e3gQRFhU8xo0aa9Pt8VKSicHNSER2Xq9YM0CGAw2BvRvFHOQ6KlO1gPJwSltlaC9%2FwJoFuYI9XBKqCqPp9ieRNDt3pQNgYMt8ogE5kt6R2tFQplTB8OGRCXOY44cNyMgT%2BF44shN5m%2BnZdtvgEFvN1Egld9jp%2FzhDvoMLj2b9lmTY1zEtAPqNis0vMW7inYY%2FQ%3D%3D&response-content-type=image/png&response-content-disposition=inline;%20filename=%22Rendez-vos-PDF-interactifs-directement-sur-Franchise-On-Cloud_v2.png%22

It's a signed temporary URL so any change will cause the signature to be voided, in this case Helpers::encodeURI will replace GoogleAccessId's %40 by @.

file_get_contents also seems to mangle the URL in some way during redirects because I end up with a 400 error from Google Cloud Storage, meaning that it understood my API's redirect but broke the URL.

Thanks for the info. The change seems fine on first look. I'll let you know if I have any feedback once I have a chance to mull it over.

I don't think the issue is with Helpers::encodeURI. When I run that sample URL through the method it returns without any changes (in the latest release). Using the URL in an image src attribute shows correct handling internally as far as I can tell. file_get_content handling could be problematic, but I don't have a valid Google Storage URL I can use for testing.

I'll give this another try in the coming weeks to verify, currently unavailable.

FYI while I'd like to confirm the issues with the in-built logic, I'll move forward with the change regardless since curl is generally more robust.

I did a test with the path+querystring from that sample URL using an online request inspector and it showed exactly what was expected. Possible that we've addressed whatever issues you were previously experiencing. If you find otherwise let me know.