Skip to content

sessions: add tiled session grid infrastructure - #338519

Closed
Megan Rogge (meganrogge) wants to merge 1 commit into
microsoft:mainfrom
meganrogge:meganrogge/sessions-grid-display
Closed

Megan Rogge (meganrogge) wants to merge 1 commit into
microsoft:mainfrom
meganrogge:meganrogge/sessions-grid-display

Conversation

@meganrogge

Copy link
Copy Markdown
Collaborator

Summary

  • add a reusable tiled layout mode for existing Sessions views without recreating chat widgets
  • preserve focus and maximized state while rearranging, and stack tiled sessions in one column on phones
  • persist and restore the grid presentation with visible-session state
  • keep tiled grids as the leading surface in the single-pane layout

Context

This extracts the provider-neutral Sessions grid infrastructure needed by #337741 into a small, independently reviewable PR. Once merged, #337741 can merge or rebase this commit and drop its duplicate infrastructure hunks.

Comparison dialogs, tools, controllers, styling, telemetry, provider changes, and Sessions-list affordances intentionally remain in #337741.

Testing

  • npm run compile-client
  • ./scripts/test.sh src/vs/sessions/test/browser/sessionGridLayout.test.ts src/vs/sessions/test/browser/sessionsPart.test.ts src/vs/sessions/test/browser/mobileSessionsPart.test.ts src/vs/sessions/test/browser/agentsPartCard.test.ts src/vs/sessions/services/sessions/test/browser/sessionsManagementService.test.ts src/vs/sessions/contrib/layout/test/browser/singlePaneStrategies.test.ts
  • npm run valid-layers-check

Add reusable grid layout state, rendering, restoration, and mobile behavior so session comparison work can build on a focused Sessions-owned contract.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings September 28, 2026 19:40
@vs-code-engineering

Copy link
Copy Markdown
Contributor

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

Benjamin Christopher Simmonds (@benibenj)

Matched files:

  • src/vs/sessions/browser/parts/mobile/mobileSessionsPart.ts
  • src/vs/sessions/browser/parts/sessionGridLayout.ts
  • src/vs/sessions/browser/parts/sessionsPart.ts
  • src/vs/sessions/browser/parts/sessionsParts.ts
  • src/vs/sessions/contrib/layout/browser/singlePane/singlePaneExistingSessionStrategy.ts
  • src/vs/sessions/contrib/layout/test/browser/layoutControllerTestUtils.ts
  • src/vs/sessions/contrib/layout/test/browser/singlePaneStrategies.test.ts

Sandeep Somavarapu (@sandy081)

Matched files:

  • src/vs/sessions/services/sessions/browser/sessionsPartService.ts
  • src/vs/sessions/services/sessions/browser/sessionsService.ts
  • src/vs/sessions/services/sessions/browser/visibleSessions.ts
  • src/vs/sessions/services/sessions/test/browser/sessionsManagementService.test.ts

Ladislau Szomoru (@lszomoru)

Matched files:

  • src/vs/sessions/services/sessions/browser/sessionsPartService.ts
  • src/vs/sessions/services/sessions/browser/sessionsService.ts
  • src/vs/sessions/services/sessions/browser/visibleSessions.ts
  • src/vs/sessions/services/sessions/test/browser/sessionsManagementService.test.ts

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Note

This error may be related to your runner configuration. You can now configure runners for Copilot code review separately from Copilot cloud agent by creating a copilot-code-review.yml file with your setup steps. Read the docs for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Sponsor
SponsoredKunjungi sekarang
Promo