[cherry-pick] sessions: preserve configured welcome name - #338540
Open
vs-code-engineering[bot] wants to merge 1 commit into
Open
vs-code-engineering[bot] wants to merge 1 commit into
vs-code-engineering[bot] wants to merge 1 commit into
Conversation
Raymond Zhao (rzhao271)
approved these changes
Sep 28, 2026
Megan Rogge (meganrogge)
enabled auto-merge (squash)
September 28, 2026 21:06
Contributor
Screenshot ChangesBase: Changed (2)
|
| Before | After |
|---|---|
sessions/sessionsList/SessionsList_NestedChatApprovals_Phone/Dark
| Before | After |
|---|---|
7 insignificant change(s) omitted (≤20 px, Δ≤2). See CI logs for details.
blocks-ci screenshots changed
Replace the contents of test/componentFixtures/blocks-ci-screenshots.md with:
Updated blocks-ci-screenshots.md
<!-- auto-generated by CI — do not edit manually -->
#### agentSessionsViewer/SessionWithPeerChat/Dark
#### agentSessionsViewer/SessionWithPeerChat/Light
#### baseUI/KeyboardFocusedToggle/Dark
#### baseUI/KeyboardFocusedToggle/DarkHighContrast
#### baseUI/KeyboardFocusedToggle/Light
#### baseUI/KeyboardFocusedToggle/LightHighContrast
#### chat/chatPetAccessoryRig/chatPetAccessoryRig/AllAccessoriesFacing/Dark
#### chat/chatPetAccessoryRig/chatPetAccessoryRig/AllAccessoriesFacing/Light
#### chat/chatPetAccessoryRig/chatPetAccessoryRig/AllRuntimeStates/Dark
#### chat/chatPetAccessoryRig/chatPetAccessoryRig/AllRuntimeStates/Light
#### chat/chatPetAccessoryRig/chatPetAccessoryRig/CoveredAntennaeComparison/Dark
#### chat/chatPetAccessoryRig/chatPetAccessoryRig/CoveredAntennaeComparison/Light
#### chat/chatPetAccessoryRig/chatPetAccessoryRig/CriticalPoses/Dark
#### chat/chatPetAccessoryRig/chatPetAccessoryRig/CriticalPoses/Light
#### chat/chatPetAccessoryRig/chatPetAccessoryRig/LiveEyeLayering/Dark
#### chat/chatPetAccessoryRig/chatPetAccessoryRig/LiveEyeLayering/Light
#### chat/chatQuestionCarousel/MarkdownLinks/Dark
#### chat/chatQuestionCarousel/MarkdownLinks/DarkHighContrast
#### chat/chatQuestionCarousel/MarkdownLinks/Light
#### chat/chatQuestionCarousel/MarkdownLinks/LightHighContrast
#### chat/input/chatInput/CompactWithProviderIcon/Dark
#### chat/input/chatInput/CompactWithProviderIcon/Light
#### chat/input/chatInput/CopilotHarnessCompactPickers/Dark
#### chat/input/chatInput/CopilotHarnessCompactPickers/Light
#### chat/petAchievements/standaloneModal/chatPetAchievementsEditor/MixedSelected/Dark
#### chat/petAchievements/standaloneModal/chatPetAchievementsEditor/MixedSelected/Light
#### comments/commentTree/CommentTreeMetadataZoomed/Dark
#### comments/commentTree/CommentTreeMetadataZoomed/DarkHighContrast
#### comments/commentTree/CommentTreeMetadataZoomed/Light
#### comments/commentTree/CommentTreeMetadataZoomed/LightHighContrast
#### editor/codeEditor/CodeEditor/Dark
#### editor/codeEditor/CodeEditor/Light
#### editor/fullwidthCharacterWidth/FullwidthCharacterWidthClassification/Dark
#### editor/fullwidthCharacterWidth/FullwidthCharacterWidthClassification/Light
#### editor/fullwidthCharacterWidth/FullwidthCharacterWidthCode/Dark
#### editor/fullwidthCharacterWidth/FullwidthCharacterWidthCode/Light
#### editor/fullwidthCharacterWidth/FullwidthCharacterWidthFont/Dark
#### editor/fullwidthCharacterWidth/FullwidthCharacterWidthFont/Light
#### editor/fullwidthCharacterWidth/FullwidthCharacterWidthProportionalFont/Dark
#### editor/fullwidthCharacterWidth/FullwidthCharacterWidthProportionalFont/Light
#### editor/fullwidthCharacterWidth/FullwidthCharacterWidthSelection/Dark
#### editor/fullwidthCharacterWidth/FullwidthCharacterWidthSelection/Light
#### editor/fullwidthCharacterWidth/FullwidthCharacterWidthTwoCells/Dark
#### editor/fullwidthCharacterWidth/FullwidthCharacterWidthTwoCells/Light
#### editor/injectedTextDecorations/ColorDecorators/Dark
#### editor/injectedTextDecorations/ColorDecorators/Light
#### editor/injectedTextDecorations/InlayHints/Dark
#### editor/injectedTextDecorations/InlayHints/Light
#### editor/injectedTextDecorations/InlineProgress/Dark
#### editor/injectedTextDecorations/InlineProgress/Light
#### editor/injectedTextDecorations/SelectedColorDecorator/Dark
#### editor/injectedTextDecorations/SelectedColorDecorator/Light
#### editor/inlineChatZoneWidget/InlineChatZoneWidget/Dark
#### editor/inlineChatZoneWidget/InlineChatZoneWidget/Light
#### editor/inlineChatZoneWidget/InlineChatZoneWidgetTerminated/Dark
#### editor/inlineChatZoneWidget/InlineChatZoneWidgetTerminated/Light
#### editor/wordWrapIndicator/WordWrapIndicator/Dark
#### editor/wordWrapIndicator/WordWrapIndicator/DarkHighContrast
#### editor/wordWrapIndicator/WordWrapIndicator/Light
#### editor/wordWrapIndicator/WordWrapIndicatorDisabled/Dark
#### editor/wordWrapIndicator/WordWrapIndicatorDisabled/Light
#### editor/wordWrapIndicator/WordWrapIndicatorFixedColumnBeyondViewport/Dark
#### editor/wordWrapIndicator/WordWrapIndicatorFixedColumnBeyondViewport/Light
#### editor/wordWrapIndicator/WordWrapIndicatorVariableLineHeight/Dark
#### editor/wordWrapIndicator/WordWrapIndicatorVariableLineHeight/Light
#### editor/wordWrapIndicator/WordWrapIndicatorViewportWrapping/Dark
#### editor/wordWrapIndicator/WordWrapIndicatorViewportWrapping/Light
#### sessions/accountMenu/petAchievementBadges/chatPetAchievementBadges/AllBadges/Dark
#### sessions/accountMenu/petAchievementBadges/chatPetAchievementBadges/AllBadges/Light
#### sessions/chat/newWidget/newChatWidget/NewSessionAttachedContext/Dark
#### sessions/chat/newWidget/newChatWidget/NewSessionAttachedContext/Light
#### sessions/chat/newWidget/newChatWidget/NewSessionAutoModel/Dark
#### sessions/chat/newWidget/newChatWidget/NewSessionAutoModel/Light
#### sessions/chat/newWidget/newChatWidget/NewSessionChatBackground/Dark
#### sessions/chat/newWidget/newChatWidget/NewSessionChatBackground/DarkHighContrast
#### sessions/chat/newWidget/newChatWidget/NewSessionChatBackground/Light
#### sessions/chat/newWidget/newChatWidget/NewSessionChatBackground/LightHighContrast
#### sessions/chat/newWidget/newChatWidget/NewSessionCompactAutoModel/Dark
#### sessions/chat/newWidget/newChatWidget/NewSessionCompactAutoModel/Light
#### sessions/chat/newWidget/newChatWidget/NewSessionExperimentalComposerBackground/Dark
#### sessions/chat/newWidget/newChatWidget/NewSessionExperimentalComposerBackground/Light
#### sessions/chat/newWidget/newChatWidget/NewSessionGitHubContextPicker/Dark
#### sessions/chat/newWidget/newChatWidget/NewSessionGitHubContextPicker/Light
#### sessions/chat/newWidget/newChatWidget/NewSessionPhoneAttachedContext/Dark
#### sessions/chat/newWidget/newChatWidget/NewSessionPhoneAttachedContext/Light
#### sessions/chat/newWidget/newChatWidget/NewSessionRemoteWorkspace/Dark
#### sessions/chat/newWidget/newChatWidget/NewSessionRemoteWorkspace/Light
#### sessions/chat/newWidget/newChatWidget/NewSessionWorkspacePicker/Dark
#### sessions/chat/newWidget/newChatWidget/NewSessionWorkspacePicker/Light
#### sessions/chat/view/chatView/AssistantResponseBackground/Dark
#### sessions/chat/view/chatView/AssistantResponseBackground/Light
#### sessions/chat/view/chatView/AssistantResponsePlain/Dark
#### sessions/chat/view/chatView/AssistantResponsePlain/Light
#### sessions/chat/view/chatView/CheckpointControlsBackground/Dark
#### sessions/chat/view/chatView/CheckpointControlsBackground/Light
#### sessions/chat/view/chatView/RequestAttachmentBackground/Dark
#### sessions/chat/view/chatView/RequestAttachmentBackground/Light
#### sessions/sessionsList/SessionsList_ArchivedNestedChat/Dark
#### sessions/sessionsList/SessionsList_ArchivedNestedChat/DarkHighContrast
#### sessions/sessionsList/SessionsList_ArchivedNestedChat/Light
#### sessions/sessionsList/SessionsList_ArchivedNestedChat/LightHighContrast
#### sessions/sessionsList/SessionsList_ArchivedNestedChatSessionMenu/Dark
#### sessions/sessionsList/SessionsList_ArchivedNestedChatSessionMenu/DarkHighContrast
#### sessions/sessionsList/SessionsList_ArchivedNestedChatSessionMenu/Light
#### sessions/sessionsList/SessionsList_ArchivedNestedChatSessionMenu/LightHighContrast
#### sessions/sessionsList/SessionsList_AutomationsNewBadge_Accent/Dark
#### sessions/sessionsList/SessionsList_AutomationsNewBadge_Accent/DarkHighContrast
#### sessions/sessionsList/SessionsList_AutomationsNewBadge_Accent/Light
#### sessions/sessionsList/SessionsList_AutomationsNewBadge_Narrow/Dark
#### sessions/sessionsList/SessionsList_AutomationsNewBadge_Narrow/DarkHighContrast
#### sessions/sessionsList/SessionsList_AutomationsNewBadge_Narrow/Light
#### sessions/sessionsList/SessionsList_AutomationsNewBadge_Running/Dark
#### sessions/sessionsList/SessionsList_AutomationsNewBadge_Running/DarkHighContrast
#### sessions/sessionsList/SessionsList_AutomationsNewBadge_Running/Light
#### sessions/sessionsList/SessionsList_AutomationsNewBadge_Soft/Dark
#### sessions/sessionsList/SessionsList_AutomationsNewBadge_Soft/DarkHighContrast
#### sessions/sessionsList/SessionsList_AutomationsNewBadge_Soft/Light
#### sessions/sessionsList/SessionsList_AutomationsNewBadge_Unread/Dark
#### sessions/sessionsList/SessionsList_AutomationsNewBadge_Unread/DarkHighContrast
#### sessions/sessionsList/SessionsList_AutomationsNewBadge_Unread/Light
#### sessions/sessionsList/SessionsList_AutomationsNewBadge/Dark
#### sessions/sessionsList/SessionsList_AutomationsNewBadge/DarkHighContrast
#### sessions/sessionsList/SessionsList_AutomationsNewBadge/Light
#### sessions/sessionsList/SessionsList_CompactChatRename/Dark
#### sessions/sessionsList/SessionsList_CompactChatRename/Light
#### sessions/sessionsList/SessionsList_CompactNeedsInput/Dark
#### sessions/sessionsList/SessionsList_CompactNeedsInput/Light
#### sessions/sessionsList/SessionsList_CompactNestedChatPrimaryAction/Dark
#### sessions/sessionsList/SessionsList_CompactNestedChatPrimaryAction/Light
#### sessions/sessionsList/SessionsList_CompactSessionRename/Dark
#### sessions/sessionsList/SessionsList_CompactSessionRename/Light
#### sessions/sessionsList/SessionsList_CompactUnreadStatusIcons/Dark
#### sessions/sessionsList/SessionsList_CompactUnreadStatusIcons/Light
#### sessions/sessionsList/SessionsList_LightweightNewButton/Dark
#### sessions/sessionsList/SessionsList_LightweightNewButton/DarkHighContrast
#### sessions/sessionsList/SessionsList_LightweightNewButton/Light
#### sessions/sessionsList/SessionsList_LightweightNewButtonWithKeybindingBackground/Dark
#### sessions/sessionsList/SessionsList_LightweightNewButtonWithKeybindingBackground/DarkHighContrast
#### sessions/sessionsList/SessionsList_LightweightNewButtonWithKeybindingBackground/Light
#### sessions/sessionsList/SessionsList_NarrowHoverToolbar/Dark
#### sessions/sessionsList/SessionsList_NarrowHoverToolbar/Light
#### sessions/sessionsList/SessionsList_NestedChatHierarchyGuides/Dark
#### sessions/sessionsList/SessionsList_NestedChatHierarchyGuides/Light
#### sessions/sessionsList/SessionsList_PeerChatInProgress/Dark
#### sessions/sessionsList/SessionsList_PeerChatInProgress/Light
#### sessions/sessionsList/SessionsList_SelectedKeyboardFocus/Dark
#### sessions/sessionsList/SessionsList_SelectedKeyboardFocus/DarkHighContrast
#### sessions/sessionsList/SessionsList_SelectedKeyboardFocus/Light
#### sessions/sessionsList/SessionsList_UnreadStatusIcons/Dark
#### sessions/sessionsList/SessionsList_UnreadStatusIcons/Light
#### workbench/activityBarMenu/CompactActivityBarMenu_CompactDensity/Dark
#### workbench/activityBarMenu/CompactActivityBarMenu_CompactDensity/DarkHighContrast
#### workbench/activityBarMenu/CompactActivityBarMenu_CompactDensity/Light
#### workbench/activityBarMenu/CompactActivityBarMenu_DefaultDensity/Dark
#### workbench/activityBarMenu/CompactActivityBarMenu_DefaultDensity/DarkHighContrast
#### workbench/activityBarMenu/CompactActivityBarMenu_DefaultDensity/Light
Patch
--- test/componentFixtures/blocks-ci-screenshots.md 2026-09-28 22:51:26.729918264 +0000
+++ /tmp/blocks-ci-updated.md 2026-09-28 23:06:16.951913583 +0000
@@ -439,7 +439,7 @@
#### sessions/sessionsList/SessionsList_SelectedKeyboardFocus/DarkHighContrast
-
+
#### sessions/sessionsList/SessionsList_SelectedKeyboardFocus/Light
Dmitriy Vasyura (dmitrivMS)
approved these changes
Sep 28, 2026
Contributor
There was a problem hiding this comment.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
Note
This error may be related to your runner configuration. You can now configure runners for Copilot code review separately from Copilot cloud agent by creating a copilot-code-review.yml file with your setup steps. Read the docs for details.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #338468 from
main.Summary
Testing
./scripts/test.sh --run src/vs/sessions/contrib/chat/test/browser/newChatWidget.test.ts(82 passing)npm run compile-client