Repository navigation
[N-API] napi_get_value_string_length return length as type too small #13458
Description
Activity
That should probably be removed from the API documentation, it’s no longer part of what Node exports. Also, you’re right, and we do use
size_tnow, which is the appropriate type for this kind of value.Reacted by Claudia MeadowsI'll take a look at updating the docs tomorrow.
- added a commit that references this issue
on Jun 6, 2017 - added a commit that references this issue
on Jun 10, 2017 - added a commit that references this issue
on Apr 16, 2018 - added a commit that references this issue
on Jul 27, 2026
As specified in the N-API documentation,
napi_get_value_string_lengthreturns the string length as anint, but the JS spec mandates it to be an unsigned integer at most 253-1. It may be more appropriate here to return auint64_tinstead.(BTW, I use "return" loosely, in reference to its out parameter.)