Skip to content

N-API: Add method to get own properties #13925

Closed
Closed
N-API: Add method to get own properties#13925
Assignees
cjihrig
Labels
node-apiIssues and PRs related to Node-API.

Description

@mhdawson
mhdawson
opened on Jun 26, 2017
  • Version: ALL
  • Platform: ALL
  • Subsystem: ALL

We need a new function to allow add-ons to get own properties consistently across versions:

```C++
napi_status napi_get_own_property(napi_env e,
                                  napi_value o,
                                  napi_propertyname p,
                                  napi_value* result);

which never walks up the prototype chain.

We also need to validate/ensure that napi_get_property() always walks up the prototype chain.

The N-API team will get to this based on priorities, but this is a good place for others to contribute as well. If you start working on this, assign the issue to yourself and add a comment that you are working on it.

Activity

  1. mhdawson
    added
    node-apiIssues and PRs related to Node-API.
    on Jun 26, 2017
  2. cjihrig
    self-assigned this
    on Jun 27, 2017

  3. cjihrig commented on Jun 27, 2017

    @cjihrig
    cjihrig
    on Jun 27, 2017
    Contributor

    Working on this.

  4. cjihrig commented on Jun 28, 2017

    @cjihrig
    cjihrig
    on Jun 28, 2017
    Contributor

    @mhdawson I added a test for napi_get_property() walking the prototype chain in #13961. I'm questioning if we really need a napi_get_own_property() though. I understand the use case, but wouldn't it be better to have napi_has_own_property(), which would correspond to Object.prototype.hasOwnProperty()?

  5. cjihrig commented on Jun 30, 2017

    @cjihrig
    cjihrig
    on Jun 30, 2017
    Contributor

    @mhdawson ping ^

  6. cjihrig
    added a commit that references this issue on Jun 30, 2017

    test: verify napi_get_property() walks prototype

    0f1888f
  7. addaleax
    added a commit that references this issue on Jul 3, 2017

    test: verify napi_get_property() walks prototype

    26ad2e6
  8. cjihrig
    added a commit that references this issue on Jul 6, 2017

    n-api: add napi_has_own_property()

    9c6804c

  9. cjihrig commented on Jul 6, 2017

    @cjihrig
    cjihrig
    on Jul 6, 2017
    Contributor

    Closing this out as the test has been added and napi_has_own_property() should be enough for users to build a get_own_property() as needed.

  10. cjihrig
    closed this as completedon Jul 6, 2017
  11. addaleax
    added 2 commits that reference this issue on Jul 11, 2017

    test: verify napi_get_property() walks prototype

    ab85fc9

    n-api: add napi_has_own_property()

    64432ae
  12. addaleax
    added 2 commits that reference this issue on Jul 18, 2017

    test: verify napi_get_property() walks prototype

    f400939

    n-api: add napi_has_own_property()

    2a86650
  13. Fishrock123
    added a commit that references this issue on Jul 19, 2017

    n-api: add napi_has_own_property()

    1b7a0cd
  14. MylesBorins
    added 2 commits that reference this issue on Apr 16, 2018

    test: verify napi_get_property() walks prototype

    a0cf9b7

    n-api: add napi_has_own_property()

    a5517d8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

node-apiIssues and PRs related to Node-API.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions
    Sponsor
    SponsoredKunjungi sekarang
    Promo