Repository navigation
response.writeHead() does not default statusMessage if it's undefined #32395
Description
- Version: 12.16.1
- Platform: Windows
- Subsystem: http
response.writeHead(statusCode[, statusMessage][, headers])
works as expected if statusMessage is omitted, supplying a default value.
However, if undefined is passed as a placeholder then it unexpectedly ignores the headers argument.
Why would I want this? Imagine a function like:
function send({ statusCode, statusMessage, headers, body } = { statusCode: 404 }, res) {
return new Promise((resolve, reject) => {
res.writeHead(statusCode, statusMessage, headers)
.end(body)
.on('finish', resolve)
.on('error', reject)
})
}You can see I depend on a single signature to work whether statusMessage is supplied or not. Otherwise, I have to:
if (statusMessage)
res.writeHead(statusCode, statusMessage, headers)
else
res.writeHead(statusCode, headers)Not the end of the world, but it lacks elegance.
Maybe this is not a bug, but wrong expectations?
Perhaps. But this expectation aligns with how javascript default parameters behave.
Activity
himself65 commentedon Mar 21, 2020
I'm working on this.
himself65 commentedon Mar 21, 2020
Yes, this not a bug, just we have a different parameter processing
spazmodius commentedon Mar 21, 2020
So, actually, this title is inaccurate: response.writeHead() does not default
statusMessageif it's undefined.statusMessageis defaulted correctly by passing the valueundefined. The problem is that then theheaders, if passed, is ignored. So a more accurate title would be: response.writeHead() misbehaves whenstatusMessageis undefinedhimself65 commentedon Mar 21, 2020
yes, and i have fixed this in that PR
http: writeHead if statusmessage is undefined dont override headers
http: writeHead if statusmessage is undefined dont override headers
http: writeHead if statusmessage is undefined dont override headers
http: writeHead if statusmessage is undefined dont override headers
http: writeHead if statusmessage is undefined dont override headers