Repository navigation
lib: refactor to use missing primordials - #38785
VoltrexKeyva wants to merge 1 commit into
Conversation
The `async_hooks` internal module is not using some of the primordials, we should use primordials whenever possible for consistency.
aduh95
left a comment
There was a problem hiding this comment.
Those were reverted in https://github.com/nodejs/node/pull/38248/files#diff-708abd8609bdfbfcb8abf61f945a9fb86b0e35f5a891f607ae1118ce8677f0e1 due to performance issue. This should not land until benchmarks are run to confirm it does not impact performance.
|
Is there something wrong with the benchmark machine? For some reason it keeps stalling/hanging or maybe the connection to Jenkins is silently being severed? I've tried restarting the job a couple times now. Normally the |
|
I think there's something wrong in the configuration that makes benchmark using an |
mcollina
left a comment
There was a problem hiding this comment.
Don’t land this, this is an incredibly hot path.
|
Seems like this is actually a really hot path, might be dangerous to land this; closing. |
The
async_hooksinternal module is not using some of the primordials, we should use primordials whenever possible for consistency.