Skip to content

doc: fix module.md headings - #56131

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
legendecas:doc/module-headings
Dec 6, 2024
Merged

nodejs-github-bot merged 1 commit into
nodejs:mainfrom
legendecas:doc/module-headings

Conversation

@legendecas

Copy link
Copy Markdown
Member
  1. Groups compilation cache APIs together (flushCompileCache, enableCompileCache, and getCompileCacheDir), under a level 2 heading Module compile cache.
    1. Fixes that flushCompileCache was under the level 2 heading Source map v3 support.
  2. Make module.stripTypeScriptTypes a level 3 heading to be nested under the level 2 heading The Module object.

@nodejs-github-bot

ghost commented Dec 4, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. module Issues and PRs related to the module subsystem. labels Dec 4, 2024
@aduh95

ghost commented Dec 4, 2024

Copy link
Copy Markdown
Contributor

Shouldn't we also move compileCacheStatus?

@legendecas

ghost commented Dec 4, 2024

Copy link
Copy Markdown
Member Author

Shouldn't we also move compileCacheStatus?

yeah, thanks, updated

@aduh95 aduh95 added dont-land-on-v18.x author ready PRs with CI started, the required approvals, and no outstanding review comments. labels Dec 4, 2024
@aduh95 aduh95 added the commit-queue PRs queued for automated landing through the Commit Queue. label Dec 4, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Dec 6, 2024
@nodejs-github-bot
nodejs-github-bot merged commit 65024ae into nodejs:main Dec 6, 2024
@nodejs-github-bot

ghost commented Dec 6, 2024

Copy link
Copy Markdown
Collaborator

Landed in 65024ae

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation. module Issues and PRs related to the module subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Sponsor
SponsoredKunjungi sekarang
Promo