Skip to content

Support for GitLab Subgroups #43

Description

@detj

GitLab offers organising projects in groups and subgroups

An example of a publicly hosted subgroup-ed project on GitLab is Gitter.

The ssh URL of which is

git@gitlab.com:gitlab-org/gitter/webapp.git

Passing the above to .fromUrl() returns undefined. The HTTPS URL https://gitlab.com/gitlab-org/gitter/webapp.git returns undefined as well.

Do you think support for this should be added ?

Activity

  1. detj commented on Feb 3, 2019

    @detj
    Author

    I looked into test/gitlab.js and only found the following assertion.

    t.is(hostinfo.ssh(), 'git@gitlab.com:111/222.git' + hash, label + ' -> ssh')
    

    That got me thinking, we would need a test case like:

    t.is(hostinfo.ssh(), 'git@gitlab.com:111/222/333.git' + hash, label + ' -> ssh')
    

    Will the above cover this case ? Or additional tests are needed ?

  2. added a commit that references this issue on Aug 20, 2019
  3. added a commit that references this issue on Sep 3, 2019
  4. added a commit that references this issue on Oct 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      Sponsor
      SponsoredKunjungi sekarang
      Promo