Repository navigation
[build] generate release docs at approval and commit them after the packages publish - #18113
Conversation
PR Summary by QodoGenerate release docs during publishing and commit them afterward
AI Description
Diagram
High-Level Assessment
Files changed (3)
|
Code Review by Qodo
1.
|
Trunk restructured the release docs flow (#18113), which collides with the runner pins here. Resolved by taking trunk's version of release.yml and update-documentation.yml and re-applying the pins on top, and by pinning the wait-for-unlock job ci.yml gained in the meantime. update-documentation.yml keeps the gh-pages concurrency guard: trunk dropped the pull --rebase retry loop in favour of a bare push, so serialising the writers is now the only thing preventing a non-fast-forward rejection.
💥 What does this PR do?
🔧 Implementation Notes
update-documentation.ymltakesgenerateandcommitbooleans (default true) in place ofskip; the release calls it per language withcommit: falseat approval and once withgenerate: falseafter the release publish, and a manual dispatch still runs both.documentation-*artifact in the run intodocs/apiand pushes once; the bindings write disjoint directories, and the pull-rebase retry loop existed only because five jobs pushed at the same time.languagesJSON list so the generate matrix is built from the tag; a patch release spawns one docs job instead of five with four skipped.🤖 AI assistance
💡 Additional Considerations
publishmatrix still uses the static language list with an inline skip and could build from the samelanguagesoutput.🔄 Types of changes