You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Adding a createFromFile method to AuthCredentials #179
We now have a createFor(String account, PrivateKey privateKey) to create AuthCredentials, what about adding a createFor(File) for creating AuthCredentials from a service account JSON file?
Notably GoogleCredential already has fromStream that reads credentials from a stream of the JSON file. If you prefer, we can go for createFor(Stream) rather than createFor(File).
Ooops sorry I missed #3. Yes this is a duplicate :(
I prefer createFor(stream) as well as it supports more uses. And I also agree that we can live without P12:
AFAIK it does not contain service_account information
It is supported just for backward compatibility with code that already used P12
GoogleCredential.createFor also supports only JSON format and states it in the javadoc. If you want to be more precise we can name it createForJson() but it kind of breaks the naming convention.
Activity
aozarov commentedon Sep 24, 2015
I would definitely prefer
createFor(stream)rather thancreateFor(File)as the latter is not supported in some systems (such as AE).Do you think this issue is a dup of #3?
In any case, I think if we add it it should only support a json content (so maybe method name should state it).
The reasons I don't think we should support p12 in this method are:
mziccard commentedon Sep 24, 2015
Ooops sorry I missed #3. Yes this is a duplicate :(
I prefer
createFor(stream)as well as it supports more uses. And I also agree that we can live without P12:GoogleCredential.createForalso supports only JSON format and states it in the javadoc. If you want to be more precise we can name itcreateForJson()but it kind of breaks the naming convention.aozarov commentedon Sep 24, 2015
We already have
createForComputeEngineandcreateForAppngine.I am fine with
createFor(Stream jsonStream)orcreateForJson(Stream)and a good javadocthat is pointing to the public docs (such as this one).
mziccard commentedon Sep 25, 2015
Closed with #180.
chore: Integrate new gapic-generator-java and rules_gapic (#179)
chore: include generated samples dir (#179)
chore(main): release 1.2.1 (#179)
chore(deps): update dependency com.google.cloud.samples:shared-config…
chore: Re-generated to pick up changes from synthtool. (#179)
ci: removing clirr from required checks (#179)
build(deps): update dependency com.google.cloud:google-cloud-shared-c…
chore(deps): update dependency com.google.cloud:google-cloud-storage-…
deps: update dependency certifi to v2022.9.24 (#179)
chore(main): release 1.1.7 (#187)
chore(main): release 1.3.0 (#172)
chore: update client_documentation link (#179)
Release v0.11.0 (#179)
Release v0.11.0 (#179)
fix: move autovalue to annotation processor path (#179)
fix: move autovalue to annotation processor path (#179)
deps: update dependency com.google.cloud:google-cloud-core-bom to v1.…