Skip to content

GAPIC auto generated code should allow manual flow control #2072

Description

@vkedia

In cloud spanner Java client, we use manual flow control for the streaming rpcs here:
https://github.com/GoogleCloudPlatform/google-cloud-java/blob/master/google-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/GrpcSpannerRpc.java#L519

We would need this support in GAPIC code as well before we can change to use that. Specifically we want to manually request for more messages from the stream rather than the client automatically getting the next message.

Activity

  1. garrettjonesgoogle commented on May 19, 2017

    @garrettjonesgoogle
    Contributor

    @vkedia , it turns out that manual flow control in grpc is experimental:

    grpc/grpc-java#1788

    So unfortunately we can't add a dependency on that until the @ExperimentalApi is removed. Otherwise, users could get broken when we upgrade the version of grpc in use.

  2. garrettjonesgoogle commented on May 20, 2017

    @garrettjonesgoogle
    Contributor

    Additionally, google-cloud-spanner's direct usage of this @ExperimentalApi feature will prevent it from going to 1.0 even if it is never added to GAX.

  3. vkedia commented on May 22, 2017

    @vkedia
    Author

    I see. Thanks for bringing this to my attention. I will talk to gRPC team and see if they have any plans to make this non experiemental.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

    Sponsor
    SponsoredKunjungi sekarang
    Promo