You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Should we overload methods for manipulating managed zone for both id and name? #610
The service API allows for identifying managed zones by both unsigned long id and String name. Our original intention was to overload methods for manipulating managed zones to accept both BigInteger id or String name. We are currently leaning towards not doing this, treating id as read-only value and identifying zones by name only for the purposes of manipulation (get, delete, apply change, list changes).
Also, there is a suggestion for providing ID as String instead of BigInteger which seems to be consistent with gcloud-python and other services.
+1 for not overloading. My reasons are mentioned here.
Also, +1 for changing the ID from BigInteger to String (which is more consistent with other services
that has both internal/read-only id and external id, such as project in resource-manager and bucket in storage).
Also, as part of this change (making dns id read-only) we should mandate that when ZoneInfo is constructed name would never be null. I think this makes sense and would work well with the Zone changes.
Activity
aozarov commentedon Feb 2, 2016
+1 for not overloading. My reasons are mentioned here.
Also, +1 for changing the ID from
BigIntegertoString(which is more consistent with other servicesthat has both internal/read-only id and external id, such as project in resource-manager and bucket in storage).
aozarov commentedon Feb 3, 2016
Also, as part of this change (making dns id read-only) we should mandate that when ZoneInfo is constructed name would never be null. I think this makes sense and would work well with the Zone changes.
mderka commentedon Feb 4, 2016
While doing this, add options for zone create method.
deps: update dependency com.google.cloud:google-cloud-shared-dependen…
chore(main): release 2.5.0 (googleapis#616)
chore: start tracking obsolete files (#610)
deps: update dependency ch.qos.logback:logback-classic to v1.2.8 (#610)
chore: release 0.122.5 (#611)
chore(deps): update dependency com.google.cloud:google-cloud-datastor…
chore: start tracking obsolete files (googleapis#610)
chore: remove distributionManagement section (#610)
chore: remove distributionManagement section (#610)
fix: release scripts from issuing overlapping phases (#610)
chore: release 1.112.2 (#604)
fix: release scripts from issuing overlapping phases (#610)
chore: release 1.112.2 (#604)
chore(master): release 1.20.0 (googleapis#610)