Repository navigation
Fix coding style problems in gcloud-pubsub-java #756
Copy link
Copy link
Closed
Labels
api: pubsubIssues related to the Pub/Sub API.Issues related to the Pub/Sub API.
Description
Output from the style checker:
Starting audit...
PublisherApiTest.java:19:8: error: Unused import: com.google.api.gax.grpc.ApiCallSettings. Use /google/src/head/depot/google3/tools/java/remove_unused_imports.py to automatically remove unused imports.
PublisherApiTest.java:34: warning: Wrong order for org.junit.After import. Use /google/src/head/depot/google3/tools/java/sort_java_imports.py to automatically sort your imports.
PublisherApiTest.java:112: error: Line is longer than 100 characters (found 109).
SubscriberApi.java:36:8: error: Unused import: com.google.api.gax.grpc.ApiCallSettings. Use /google/src/head/depot/google3/tools/java/remove_unused_imports.py to automatically remove unused imports.
SubscriberApi.java:192: error: Line is longer than 100 characters (found 102).
SubscriberApi.java:509: error: Line is longer than 100 characters (found 101).
SubscriberApi.java:631: error: Line is longer than 100 characters (found 102).
SubscriberSettings.java:225: error: Line is longer than 100 characters (found 101).
SubscriberSettings.java:319:7: warning: Name 'LIST_SUBSCRIPTIONS_PAGE_STR_DESC' must match pattern '^[a-z][a-zA-Z0-9]*_?$'.
PublisherApi.java:36:8: error: Unused import: com.google.api.gax.grpc.ApiCallSettings. Use /google/src/head/depot/google3/tools/java/remove_unused_imports.py to automatically remove unused imports.
PublisherApi.java:189: error: Line is longer than 100 characters (found 101).
testing/LocalPublisherImpl.java:82: error: Line is longer than 100 characters (found 109).
PublisherSettings.java:289:7: warning: Name 'LIST_TOPICS_PAGE_STR_DESC' must match pattern '^[a-z][a-zA-Z0-9]*_?$'.
PublisherSettings.java:314:7: warning: Name 'LIST_TOPIC_SUBSCRIPTIONS_PAGE_STR_DESC' must match pattern '^[a-z][a-zA-Z0-9]*_?$'.
SubscriberApi.java:36:8: error: Unused import: com.google.api.gax.grpc.ApiCallSettings. Use /google/src/head/depot/google3/tools/java/remove_unused_imports.py to automatically remove unused imports.
SubscriberApi.java:192: error: Line is longer than 100 characters (found 102).
SubscriberApi.java:509: error: Line is longer than 100 characters (found 101).
SubscriberApi.java:631: error: Line is longer than 100 characters (found 102).
SubscriberSettings.java:225: error: Line is longer than 100 characters (found 101).
SubscriberSettings.java:319:7: warning: Name 'LIST_SUBSCRIPTIONS_PAGE_STR_DESC' must match pattern '^[a-z][a-zA-Z0-9]*_?$'.
PublisherApi.java:36:8: error: Unused import: com.google.api.gax.grpc.ApiCallSettings. Use /google/src/head/depot/google3/tools/java/remove_unused_imports.py to automatically remove unused imports.
PublisherApi.java:189: error: Line is longer than 100 characters (found 101).
PublisherSettings.java:289:7: warning: Name 'LIST_TOPICS_PAGE_STR_DESC' must match pattern '^[a-z][a-zA-Z0-9]*_?$'.
PublisherSettings.java:314:7: warning: Name 'LIST_TOPIC_SUBSCRIPTIONS_PAGE_STR_DESC' must match pattern '^[a-z][a-zA-Z0-9]*_?$'.
Audit done.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
api: pubsubIssues related to the Pub/Sub API.Issues related to the Pub/Sub API.
Activity
garrettjonesgoogle commentedon Nov 22, 2016
We have fixed the style issues.
chore(main): release 3.4.1 (#756)
chore(main): release 2.3.3-SNAPSHOT (#756)
deps: update dependency com.google.cloud:google-cloud-shared-dependen…
chore(main): release 1.2.10 (googleapis#757)
chore: add native image checks as required (#756)
fix: enable longpaths support for windows test (#1485) (#756)
chore(main): release 2.3.3-SNAPSHOT (#756)
chore(main): release 2.3.5-SNAPSHOT (#756)
Revert "chore: pin versions of dependencies for compatibility with Py… (
chore(main): release 2.2.6 (#754)
14 remaining items
chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 - fo…
chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 - fi…
chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 - si…
refactor: Revert JUnit5 to JUnit4 (#969)
refactor: migration tests in appengine module from JUnit4 to JUnit5 (#…
refactor: migration tests in credentials module from JUnit4 to JUnit5 (…
chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 - fi…
chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 - se…
chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 - th…
chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 - fo…
chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 - fi…
chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 - si…
refactor: Revert JUnit5 to JUnit4 (#969)
chore: cleanup cloud RAD generation (#1269) (#756)
chore: cleanup cloud RAD generation (#1269) (#756)