Skip to content

Rename class DnsRecord #779

Description

@mderka

This was pointed out by the DNS team.

Activity

  1. added this to the milestone on Mar 23, 2016
  2. self-assigned this
    on Mar 23, 2016
  3. jgeewax commented on Mar 23, 2016

    @jgeewax

    Errr - really? I don't love this... can we debate a bit more first.... ?

  4. mderka commented on Mar 23, 2016

    @mderka
    Author

    Oh, I did not realize this. We certainly can. Both Jacob and @aozarov thought that this was a good idea, and I kind of agree. I am restoring the comment in the doc and pausing here.

  5. changed the title [-]Rename class DnsRecord to ResourceRecordSet[/-] [+]Rename class DnsRecord[/+] on Mar 23, 2016
  6. mderka commented on Mar 23, 2016

    @mderka
    Author

    I renamed the issue. The final name is to be decided after some discussion. The suggestions are DnsRecordSet and ResourceRecordSet.

  7. ajkannan commented on Mar 23, 2016

    @ajkannan

    I slightly prefer DnsRecordSet over ResourceRecordSet, but I'm fine with either. RecordSet would be shorter; do you think it's a clear enough name?

  8. aozarov commented on Mar 23, 2016

    @aozarov
    Contributor

    Errr - really? I don't love this... can we debate a bit more first.... ?

    The issue is that what we call DnsRecord does not actually represent one DNS record but rather a set of records (and therefore is called in the underlying service API ResourceRecordSet).

    BTW, it looks like this long name was adopted by gcloud-python though node choose Record (which I personally think is wrong).

    I think the main point is to indicate that it is a set rather than an individual item and therefore my ordered preference would be: RecordSet, DnsRecordSet, ResourceRecordSet.
    With a much stronger preference to the first.

  9. mderka commented on Mar 23, 2016

    @mderka
    Author

    After some discussion both here and internally, including the input from the DNS team, we will rename to RecordSet.

  10. added 4 commits that reference this issue on Mar 23, 2016
    139d930
    bc51bd1
    1a5aade
    96e28d6
  11. 14 remaining items

  12. added a commit that references this issue on Dec 22, 2025
  13. added a commit that references this issue on Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

api: dnsIssues related to the Cloud DNS API.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

    Sponsor
    SponsoredKunjungi sekarang
    Promo