Update profile subpages by carlos-zamora · Pull Request #20336 · microsoft/terminal

Carlos Zamora (carlos-zamora) · 2026-06-18T22:24:30Z

Summary of the Pull Request

Updates the individual profile pages to include:

icons + settings expanders/cards
SettingsResetButton: a new "reset value" button
a new "unfocused appearance" subpage with its own preview (similar to default appearance)

Detailed Description of the Pull Request / Additional comments

IInheritableViewModel: interface exposing HasSetting(), ClearSetting(), and SettingOverrideSource()
To help ensure that these are updated properly, a static assert was added that checks the number of profile settings. This is intended to be a tripwire to ensure future changes also update the reset buttons.
Profiles_UnfocusedAppearance.h/cpp/idl/xaml: the new unfocused appearance page
added helper functions FormatAccessibleName() and ColorToHexString() to deduplicate code that creates accessible names for SettingsExpanders across the entire SUI

Validation Steps Performed

settings search + deep link navigation
"reset value" button
accessibility pass with Narrator

PR Checklist

Related to #17000

Carlos Zamora (carlos-zamora) · 2026-06-18T22:31:22Z

Demo

Profiles_Base

Profiles_UnfocusedAppearance

Tooltips

Carlos Zamora (carlos-zamora) · 2026-06-18T23:33:37Z

+
+        // Optional resource name for a secondary label shown beneath the primary label in
+        // search results (i.e. "Nav_ProfileDefaults/Content" for the profile-defaults page links).
+        // Empty for most entries.
+        // NOTE: wrapped in USES_RESOURCE() (when set) for the same compile-time validation as ResourceName.
+        wil::zwstring_view SecondaryResourceName;


The SecondaryResourceName changes in this file conflict with #20199 . They both have basically the same implementation with a different variable name. The consumer in SearchIndex.cpp also needs to be updated.

I'll go in and make this match the one from the other one.

Actually, turns out that it's a more complex merge conflict. I'll just have to deal with it when we start merging these PRs into main.

Carlos Zamora (carlos-zamora) · 2026-07-30T21:13:55Z

Updated base branch (PR #20232) with a SettingsExpander collapse animation fix. Force pushed a rebase off of that.

Removes most of the em-dashes in our repo. Any related to the Settings UI are covered in #20336.

Dustin L. Howett (DHowett) · 2026-08-26T20:47:27Z

+        void _OnClick(const Windows::Foundation::IInspectable& sender, const Windows::UI::Xaml::RoutedEventArgs& args);
+        hstring _GenerateOverrideMessage(const Windows::Foundation::IInspectable& settingOrigin);
+
+        Windows::UI::Xaml::Data::INotifyPropertyChanged _subscribedTarget{ nullptr };


will this create a reference cycle, where the page is holding a strong reference to the button and the button is holding a strong reference to the page? are we going to leak a bunch of SUI stuff when we close it? (honestly don't know)

There's no reference cycle here, but there was a memory leak because the subscription was never revoked. Fixed that.

For reference (heh), the reference graph is more like:

Page -- strong ref --> reset button

reset button -- strong ref --> view model (aka Target)

view model -- weak ref --> button (now _targetPropertyChangedRevoker)

…xpanders

Carlos Zamora (carlos-zamora) · 2026-09-04T19:53:17Z

Dustin L. Howett (@DHowett) this one should be good to go now.

Carlos Zamora (carlos-zamora) · 2026-09-08T18:26:05Z

Also want to follow up on this piece of feedback in the bug bash notes:

apart from the Name of the profile, everything in the top section is the "Task" which is launched (what, where, how). Is this a good opportunity to add that verbiage?

I do like the idea of referring to this group of settings as something like "Task settings" or "Process settings". They definitely feel more fundamental than the rest. The problem I'm running into is more that we're already using the term "profile" for this concept. I'm concerned that changing the Expander.Header to "Task" deviates from that design decision just a little more than I'm comfortable with.

We could move Name and the delete button out, but I think that's too much of a deviation from the agreed upon design.

Conversely, we could update the header to use the term "Task". Maybe even only update the header for profile defaults. The issue I have there is that we're using an expander for those two settings and a header for the rest.

Long term, I think I'm more open to the idea of using "Task" thoughout the UI (i.e. settings UI, command palette, snippets?). We probably want to do a full pass on the nomenclature used and make sure that we're reusing the same terms when possible: "profile", "task", "session", "pane".

Dustin L. Howett (DHowett) · 2026-09-08T18:29:57Z

The problem I'm running into is more that we're already using the term "profile" for this concept.

So, the way I've justified it to myself is that a task is part of a profile.

A profile consists of three things: a task (what do we run, how do we run it?), behaviors (does OSC 777 work? what happens when the task exits? can the task write to the clipboard?) and appearance (you know this one)

Everything on this page is part of the profile. So it doesn't seem wrong or even a violation of the terms we're currently using to add Task, as a header, inside the profile page.

--

Conversely I could argue that the current setup is incorrect because it says "Welcome to the Profile editor, would you like to edit the Profile part of the Profile?" And inside that box is only the command line, starting directory, etc.; and then I can imagine a user asking "If that's the profile, what are these other things in the profile page?"

Dustin L. Howett (DHowett) · 2026-09-08T18:38:49Z

FWIW, a proposed glossary:

Task: thing to launch, where and how
Appearance: how it looks
Behaviors: how it acts
Profile: Task + appearance + behaviors
Session: a running instance of a profile (we started the task, applied the appearance, act in accordance with behaviors)
Pane: a place in the UI where a session is presented.

Execution/launching turns a profile into a session, and the session is put into a pane.

Dustin L. Howett (DHowett) · 2026-09-08T18:40:38Z

One place where this distinction matters is that when we get a handoff, all we have is a task (!) and we need to collect it with some sane behaviors and a sane appearance and pass it off as a session to be hosted in a pane.

…/profile-rejuv # Conflicts: # src/cascadia/TerminalSettingsEditor/MainPage.cpp # src/cascadia/TerminalSettingsEditor/Resources/de-DE/Resources.resw # src/cascadia/TerminalSettingsEditor/Resources/es-ES/Resources.resw # src/cascadia/TerminalSettingsEditor/Resources/fr-FR/Resources.resw # src/cascadia/TerminalSettingsEditor/Resources/it-IT/Resources.resw # src/cascadia/TerminalSettingsEditor/Resources/ja-JP/Resources.resw # src/cascadia/TerminalSettingsEditor/Resources/ko-KR/Resources.resw # src/cascadia/TerminalSettingsEditor/Resources/pt-BR/Resources.resw # src/cascadia/TerminalSettingsEditor/Resources/qps-ploc/Resources.resw # src/cascadia/TerminalSettingsEditor/Resources/qps-ploca/Resources.resw # src/cascadia/TerminalSettingsEditor/Resources/qps-plocm/Resources.resw # src/cascadia/TerminalSettingsEditor/Resources/ru-RU/Resources.resw # src/cascadia/TerminalSettingsEditor/Resources/zh-CN/Resources.resw # src/cascadia/TerminalSettingsEditor/Resources/zh-TW/Resources.resw

…rite them

…/profile-rejuv

Dustin L. Howett (DHowett)

I can't be the last approver, but I do approve everything before this

Dustin L. Howett (DHowett) · 2026-09-15T21:34:33Z

        Automation::AutomationProperties::SetName(NewKeyBinding(), RS_(L"EditAction_NewKeyBinding/Header"));
    }

+    // The browse buttons live inside data templates, so we can't reference them by name.


i feel like we could just use their Uids in the resw file

…26 22:10:12 (#20688) Co-authored-by: Console Service Bot <consvc@microsoft.com>

amalamal0104-hub · 2026-09-26T10:30:08Z

    // Nom de ressource facultatif pour une étiquette secondaire affichée sous l'étiquette principale dans
    // résultats de recherche (c.-à-d. « Nav_ProfileDefaults/Content » pour les liens de la page des paramètres par défaut du profil).
    // Vide pour la plupart des entrées.
    // REMARQUE : enveloppé dans USES_RESOURCE() (lorsqu’il est défini) pour la même validation au moment de la compilation que ResourceName.
    wil::zwstring_view SecondaryResourceName;

Carlos Zamora (carlos-zamora) commented Jun 18, 2026

View reviewed changes

Carlos Zamora (carlos-zamora) force-pushed the dev/cazamor/sui-rejuv/profile-rejuv branch from 236afe3 to 3faedd8 Compare July 30, 2026 20:34

github-advanced-security Bot found potential problems Jul 30, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

Base automatically changed from dev/cazamor/sui-rejuv/setting-container to main August 24, 2026 23:20

Carlos Zamora (carlos-zamora) force-pushed the dev/cazamor/sui-rejuv/profile-rejuv branch 2 times, most recently from 3ed0ad5 to ae1f638 Compare August 26, 2026 18:40

Carlos Zamora (carlos-zamora) mentioned this pull request Aug 26, 2026

Remove em-dash usage #20611

Merged

Carlos Zamora (carlos-zamora) added a commit that referenced this pull request Aug 26, 2026

Remove em-dash usage (#20611)

8c0a234

Removes most of the em-dashes in our repo. Any related to the Settings UI are covered in #20336.

Carlos Zamora (carlos-zamora) added the zBugBash-Consider label Aug 31, 2026

Dustin L. Howett (DHowett) reviewed Aug 31, 2026

View reviewed changes

github-advanced-security Bot found potential problems Sep 3, 2026

View reviewed changes

Comment thread src/cascadia/TerminalSettingsEditor/MainPage.cpp Fixed

This comment has been minimized.

Sign in to view

This comment was marked as resolved.

Sign in to view

Carlos Zamora (carlos-zamora) added 14 commits September 3, 2026 16:57

reduce loc burden + fix navigator handling

70c1327

add reset button

e0eb52e

add unfocused appearance subpage

b8de0bb

spellcheck

c289eaa

fix merge conflicts

0e8f94d

fix spacing

1c70195

be gone em dashes!

7da0800

update starting directory UI + disable logic

24b2642

Replace auto-generating UnfApp logic with explicit generation

f9ccde8

Improve navigator labels + descriptions

4f7f2fb

Visual/UI Affordance --> Tab Appearance

bccea70

Fix SettingResetButton memory leak

ede9bda

fallback -> fall back

db46173

Improve focus behavior when using SettingResetButton

a09c831

Carlos Zamora (carlos-zamora) added 3 commits September 3, 2026 18:55

Align reset buttons on pages w/ expanders

1c83ed7

consistently use folder icon button for 'Browse...'

a64e712

add/deduplicate accessible name logic + remove phantom tab stop for e…

24f401c

…xpanders

Carlos Zamora (carlos-zamora) force-pushed the dev/cazamor/sui-rejuv/profile-rejuv branch from 906e7b9 to 24f401c Compare September 4, 2026 18:57

Carlos Zamora (carlos-zamora) assigned Dustin L. Howett (DHowett) Sep 4, 2026

Carlos Zamora (carlos-zamora) added 2 commits September 8, 2026 09:50

Merge branch 'main' into dev/cazamor/sui-rejuv/profile-rejuv

5bb12b2

Fix expander for Profile Defaults

ecfd064

Dustin L. Howett (DHowett) added 3 commits September 10, 2026 19:18

Unfrick the format

390b885

Restore the sr-Cyrl_RS and uk-UA translations b/c TDBuild won't overw…

f36742f

…rite them

Dustin L. Howett (DHowett) mentioned this pull request Sep 15, 2026

Settings -> Profiles -> [Profile] -> Terminal Emulation does not open #20682

Closed

Dustin L. Howett (DHowett) added 3 commits September 15, 2026 16:20

Merge remote-tracking branch 'origin/main' into dev/cazamor/sui-rejuv…

49ff95c

…/profile-rejuv

remove clod-isms

3406c02

don't use a weak reference here

c60e1a4

Dustin L. Howett (DHowett) approved these changes Sep 15, 2026

View reviewed changes

PankajBhojwani approved these changes Sep 15, 2026

View reviewed changes

Localization Updates - dev/cazamor/sui-rejuv/profile-rejuv - 09/15/20…

e91a118

…26 22:10:12 (#20688) Co-authored-by: Console Service Bot <consvc@microsoft.com>

Dustin L. Howett (DHowett) approved these changes Sep 15, 2026

View reviewed changes

PankajBhojwani approved these changes Sep 15, 2026

View reviewed changes

Dustin L. Howett (DHowett) merged commit c0c72e9 into main Sep 15, 2026
17 of 20 checks passed

Dustin L. Howett (DHowett) deleted the dev/cazamor/sui-rejuv/profile-rejuv branch September 15, 2026 22:55

Conversation

Carlos Zamora (carlos-zamora) commented Jun 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of the Pull Request

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

PR Checklist

Uh oh!

Carlos Zamora (carlos-zamora) commented Jun 18, 2026

Demo

Profiles_Base

Profiles_UnfocusedAppearance

Tooltips

Uh oh!

Carlos Zamora (carlos-zamora) Jun 18, 2026

Choose a reason for hiding this comment

Uh oh!

Carlos Zamora (carlos-zamora) Jul 30, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

Carlos Zamora (carlos-zamora) commented Jul 30, 2026

Uh oh!

Uh oh!

Uh oh!

Dustin L. Howett (DHowett) Aug 26, 2026

Choose a reason for hiding this comment

Uh oh!

Carlos Zamora (carlos-zamora) Sep 3, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This comment has been minimized.

This comment was marked as resolved.

Carlos Zamora (carlos-zamora) commented Sep 4, 2026

Uh oh!

Carlos Zamora (carlos-zamora) commented Sep 8, 2026

Uh oh!

Dustin L. Howett (DHowett) commented Sep 8, 2026

Uh oh!

Dustin L. Howett (DHowett) commented Sep 8, 2026

Uh oh!

Dustin L. Howett (DHowett) commented Sep 8, 2026

Uh oh!

Dustin L. Howett (DHowett) left a comment

Choose a reason for hiding this comment

Uh oh!

Dustin L. Howett (DHowett) Sep 15, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

amalamal0104-hub commented Sep 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Carlos Zamora (carlos-zamora) commented Jun 18, 2026 •

edited

Loading