Repository navigation
Fix Export Tab leaking Enter via Command Palette - #20358
Merged
Dustin L. Howett (DHowett) merged 1 commit intoJul 10, 2026
Merged
Conversation
2 of 4 tasks
Dustin L. Howett (DHowett)
approved these changes
Jul 10, 2026
Dustin L. Howett (DHowett)
deleted the
dev/cazamor/bugfix/export-text-enter
branch
July 10, 2026 20:47
Dustin L. Howett (DHowett)
pushed a commit
that referenced
this pull request
Jul 10, 2026
## Summary of the Pull Request Fixes a bug where Enter would leak into the terminal session when running the export buffer command from the command palette. Turns out this is because `_ExportTab()` opens the file picker synchronously in the key handler. The file picker spins a nested Win32 modal message loop, which pumps the queued `WM_CHAR` into the terminal. Switching to the foreground thread gets out of the nested modal loop, resulting in the `WM_CHAR` being handled through XAML's pipeline and suppressing it normally. The low priority makes it so that the command palette is visibly dismissed before opening the file picker. ## Validation Steps Performed Run export buffer action from the command palette. ✅ Enter does not go through to the underlying terminal. ## PR Checklist Closes #20188 Based on #20221 (cherry picked from commit 0144184) Service-Card-Id: PVTI_lADOAF3p4s4BBcTlzgwpi5g Service-Version: 1.24
Dustin L. Howett (DHowett)
pushed a commit
that referenced
this pull request
Jul 10, 2026
## Summary of the Pull Request Fixes a bug where Enter would leak into the terminal session when running the export buffer command from the command palette. Turns out this is because `_ExportTab()` opens the file picker synchronously in the key handler. The file picker spins a nested Win32 modal message loop, which pumps the queued `WM_CHAR` into the terminal. Switching to the foreground thread gets out of the nested modal loop, resulting in the `WM_CHAR` being handled through XAML's pipeline and suppressing it normally. The low priority makes it so that the command palette is visibly dismissed before opening the file picker. ## Validation Steps Performed Run export buffer action from the command palette. ✅ Enter does not go through to the underlying terminal. ## PR Checklist Closes #20188 Based on #20221 (cherry picked from commit 0144184) Service-Card-Id: PVTI_lADOAF3p4s4BQX0-zgwpi5c Service-Version: 1.25
Tarori (tarori)
pushed a commit
to tarori/terminal
that referenced
this pull request
Sep 15, 2026
## Summary of the Pull Request Fixes a bug where Enter would leak into the terminal session when running the export buffer command from the command palette. Turns out this is because `_ExportTab()` opens the file picker synchronously in the key handler. The file picker spins a nested Win32 modal message loop, which pumps the queued `WM_CHAR` into the terminal. Switching to the foreground thread gets out of the nested modal loop, resulting in the `WM_CHAR` being handled through XAML's pipeline and suppressing it normally. The low priority makes it so that the command palette is visibly dismissed before opening the file picker. ## Validation Steps Performed Run export buffer action from the command palette. ✅ Enter does not go through to the underlying terminal. ## PR Checklist Closes microsoft#20188 Based on microsoft#20221 (cherry picked from commit 0144184) Service-Card-Id: PVTI_lADOAF3p4s4BBcTlzgwpi5g Service-Version: 1.24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Fixes a bug where Enter would leak into the terminal session when running the export buffer command from the command palette.
Turns out this is because
_ExportTab()opens the file picker synchronously in the key handler. The file picker spins a nested Win32 modal message loop, which pumps the queuedWM_CHARinto the terminal.Switching to the foreground thread gets out of the nested modal loop, resulting in the
WM_CHARbeing handled through XAML's pipeline and suppressing it normally. The low priority makes it so that the command palette is visibly dismissed before opening the file picker.Validation Steps Performed
Run export buffer action from the command palette.
✅ Enter does not go through to the underlying terminal.
PR Checklist
Closes #20188
Based on #20221