Node 10.0.0 Object.values() returns incorrect array

Version: v10.0.0
Platform: Darwin Kernel Version 17.5.0: Mon Mar 5 22:24:32 PST 2018; root:xnu-4570.51.1~1/RELEASE_X86_64 x86_64

To reproduce the problem, create the following js files:

values.js

"use strict";
Object.defineProperty(exports, "__esModule", { value: true });
class X {
}
exports.X = X;

test.js

const x = require('./values.js');
console.log(x);
console.log(Object.values(x));

test1.js

const x = require('./values.js');
console.log(Object.values(x));

Now node test prints:

{ X: [Function: X] }
[]

Interestingly, node test1 prints:

[ [Function: X] ]

Please note Object.values(x) in test.js returns []. I expect it to print:

{ X: [Function: X] }
[ [Function: X] ]

I tried Node 8.x, both test and test1 work as expected.

@AyushG3112

@AyushG3112 Are you sure? I can definitely reproduce, on multiple platforms.

@apapirovski

@apapirovski nevermind, looks like my PC had some version conflicts while installing v10.0.0 from nvm. Will try fixing those and will try again. (deleting previous comment till then)

Ouch...

'use strict';
const obj = {};
Object.defineProperty(obj, 'ibreakyourobjects', { value: true });
obj.X = true;
console.log(Object.values(obj));
// [ true ]
Object.keys(obj);
console.log(Object.values(obj));
// []

ping @nodejs/v8 this looks bad to me...

Also, adding enumerable: true on ibreakyourobjects fixes the bug... (setting it to false breaks it again)

I can definitely reproduce this in Chromium 66.0.3359.117.

Also, swapping order of declarations like so:

'use strict';
const obj = {};
obj.X = true;
Object.defineProperty(obj, 'ibreakyourobjects', { value: true });
obj.Y =  true;
console.log(Object.values(obj));
// [ true, true ]
Object.keys(obj);
console.log(Object.values(obj));
// [ true ]

Note how the one before the defineProperty is still there but the one after isn't.

Edit: I can reproduce on 67.0.3396.10

I can reproduce in V8, and will bisect.

I can reproduce with V8 canary.

Opened https://bugs.chromium.org/p/v8/issues/detail?id=7687 upstream.

chore: make the code compatible with node 10.0.0

V8 issue with the recent optimizations for speed of Object.values and Object.entries: https://bugs.chromium.org/p/chromium/issues/detail?id=836145&can=2&start=0&num=100&q=&colspec=ID%20Pri%20M%20Stars%20ReleaseBlock%20Component%20Status%20Owner%20Summary%20OS%20Modified&groupby=&sort=

chore: make the code compatible with node 10.0.0

deps: cherry-pick 76cab5f from upstream V8

Navigation Menu

Repository navigation

Node 10.0.0 Object.values() returns incorrect array #20278

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Node 10.0.0 Object.values() returns incorrect array #20278

Description

Activity

apapirovski commented on Apr 25, 2018

AyushG3112 commented on Apr 25, 2018

apapirovski commented on Apr 25, 2018

apapirovski commented on Apr 25, 2018

ChALkeR commented on Apr 25, 2018

apapirovski commented on Apr 25, 2018

hashseed commented on Apr 25, 2018

targos commented on Apr 25, 2018

xaviergonz commented on Apr 25, 2018

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions