Repository navigation
Test Runner: delegate arbitrary output formatting to each reporter #48011
Description
What is the problem this feature will solve?
The current implementation of the test runner (--test) is very TAP oriented,
so we have decided (#43525 (comment), #45618) to treat any arbitrary output as a test diagnostic.
I do agree this decision makes sense when using TAP as the reporter, but I think we can provide better DX for console logs or other arbitrary output when using other reporters.
What is the feature you are proposing to solve the problem?
add a new event emitted by TestsStream, perhaps test:stdout or test:unknown (or whatever) so each reporter can decide how to treat unknown output.
I think console.log("test") should show the same when running node --test-reporter spec test.js and node --test --test-reporter spec test.js (probably also the same colors etc, but that probably justifies a separate issue)
What alternatives have you considered?
No response
Activity
MoLow commentedon May 15, 2023
CC @nodejs/test_runner
MoLow commentedon May 15, 2023
one thing that is TAP oriented and might be harder to change is the fact we direct any output on
stderrtostdout- but that might make sense in the context of a test runner.HinataKah0 commentedon May 15, 2023
Hi @MoLow ,
Is anyone from test runner team working on it? Or is it open for anyone to try?
It seems that it's still being discussed 🤔
MoLow commentedon May 15, 2023
@HinataKah0 I first want to gather feedback regarding this issue, then it makes sense to only work on it after #47867 lands
MoLow commentedon May 16, 2023
I have discussed this with @cjihrig and he says it makes sense to him.
@HinataKah0 do you want to implement this?
HinataKah0 commentedon May 17, 2023
I'll be happy to try 😄
Will send a PR so we can discuss as well (I hope I don't misunderstand anything)
cjihrig commentedon May 17, 2023
I think it makes sense for the test runner to collect both stdout and stderr from the child processes and direct them to the same place. For example, if the reporter destination is a file, having stdout and stderr both sent to the file is helpful for reviewing the output at a later time. If stderr is not sent to the reporter destination, there would be no way of recovering it later.
test_runner: delegate stderr and stdout formatting to reporter
test_runner: delegate stderr and stdout formatting to reporter
test_runner: delegate stderr and stdout formatting to reporter
test_runner: delegate stderr and stdout formatting to reporter
test_runner: delegate stderr and stdout formatting to reporter
test_runner: delegate stderr and stdout formatting to reporter