v8: move serdes to internalBinding - #22161
Merged
Merged
Conversation
32 of 33 tasks
BridgeAR
approved these changes
Aug 6, 2018
Member
Author
targos
approved these changes
Aug 6, 2018
addaleax
approved these changes
Aug 6, 2018
cjihrig
approved these changes
Aug 7, 2018
TimothyGu
approved these changes
Aug 7, 2018
Contributor
|
CITGM ( |
trivikr
approved these changes
Aug 7, 2018
maclover7
approved these changes
Aug 7, 2018
maclover7
left a comment
Contributor
There was a problem hiding this comment.
CITGM results look okay, LGTM if CI passes
jasnell
approved these changes
Aug 7, 2018
tniessen
approved these changes
Aug 7, 2018
fhinkel
approved these changes
Aug 8, 2018
PR-URL: nodejs#22161 Refs: nodejs#22160 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
devsnek
force-pushed
the
serdes-to-internal
branch
from
August 8, 2018 22:25
4caef72 to
cf3bb59
Compare
Member
Author
|
landed in cf3bb59 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #22160
/cc @addaleax @jasnell
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes